RFR: 8371536: C2: VerifyIterativeGVN should assert on first detected failure [v6]

[Benoît Maillard]

On Thu, 18 Dec 2025 13:48:01 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Remove trailing whitespace
>>  - Merge branch 'master' into JDK-8371536
>>  - More style
>>  - Style and comments
>>  - Merge branch 'master' into JDK-8371536
>>  - Assert directly in the verify methods
>>  - Add comment for _table.hash_delete(n)
>>  - Change assert to print only the cause and the node name
>>    
>>    Bring back old comment
>>    
>>    Wording
>>  - Assert at first failure
>>  - Remove node from hash table before calling Ideal in verification
>
> src/hotspot/share/opto/phaseX.cpp line 1090:
> 
>> 1088:       // We should either make sure that this node is properly added back to the IGVN worklist
>> 1089:       // in PhaseIterGVN::add_users_to_worklist to update it again or add an exception
>> 1090:       // in the verification code above if that is not possible for some reason (like Load nodes).
> 
> You moved the comment. It used to make sense to refer to "exceptions above". Now the exceptions are inside the methods, relative to the new place of the comment ;)

Good catch :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28295#discussion_r2634261375