RFR: 8374078: C2_MacroAssembler::verify_int_in_range has incorrect early return condition

Dean Long dlong at openjdk.org
Sat Dec 20 00:13:00 UTC 2025


On Fri, 19 Dec 2025 04:00:31 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Hi,
> 
> This PR fixes the incorrect early return condition in `C2_MacroAssembler::verify_int_in_range`. Previously, `lo == min_jint && hi == max_jint` is equivalent to `t == Type::INT`. But this is not true anymore.
> 
> Please take a look and leave your reviews, thanks a lot.

The simplest solution is to just return instead of ShouldNotReachHere() when this condition is detected, because as you said, these functions do not have complete coverage of TypeInt properties.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28916#issuecomment-3677057230


More information about the hotspot-compiler-dev mailing list