RFR: 8373525: C2: assert(_base == Long) failed: Not a Long [v2]

[Damon Fenacci]

On Fri, 19 Dec 2025 16:17:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> Otherwise, looks good to me, too, thanks!

Thanks for your suggestions @chhagedorn. I've just addressed them.

> src/hotspot/share/opto/addnode.cpp line 1603:
> 
>> 1601:           const TypeLong* x_long = phase->type(x)->isa_long();
>> 1602:           // Collapsed graph not equivalent if potential over/underflow -> bailing out (*)
>> 1603:           if (x_long == nullptr || can_overflow(x_long, con1->get_long() + con2->get_long())) {
> 
> I suggest to to add a comment about when `x_long` is not a long as described in the PR description.

I added a comment a few lines above.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28920#issuecomment-3680912227
PR Review Comment: https://git.openjdk.org/jdk/pull/28920#discussion_r2638990557