RFR: 8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces [v3]
Leonid Mesnik
lmesnik at openjdk.org
Sat Dec 27 21:00:00 UTC 2025
On Sat, 27 Dec 2025 05:15:56 GMT, Kirill Shirokov <duke at openjdk.org> wrote:
>> This PR addresses the trailing whitespaces for a .py test.
>>
>> They were introduced in commit 916694f2c1e7fc8d6a88e7026bc2d29ba2923849 and not detected by jcheck, since checking *.py for whitespaces is not enabled in .jcheck/conf.
>>
>> So, a separate question is: do you think that a pattern for Python files should be added to [checks "whitespace"] section of .jcheck/conf?
>
> Kirill Shirokov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8344345-clean-up-trailing-spaces
> - Merge branch 'master' into JDK-8344345-clean-up-trailing-spaces
> - 8344345: File test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces
>> So, a separate question is: do you think that a pattern for Python files should be added to [checks "whitespace"] section of .jcheck/conf?
Yes, please file issue for this or add a a part of this fix if all other .py files are fine.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27058#issuecomment-3694220050
More information about the hotspot-compiler-dev
mailing list