RFR: 8349142: [JMH] compiler.MergeLoadBench.getCharBV fails [v2]
SendaoYan
syan at openjdk.org
Sun Feb 2 02:48:59 UTC 2025
On Fri, 31 Jan 2025 16:42:30 GMT, Chen Liang <liach at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove Unsafe.ARRAY_BYTE_BASE_OFFSET from second argument of VarHandle.get
>
> Looks good, thanks for fixing these misuses of Unsafe.ARRAY_BYTE_BASE_OFFSET. Looks like a copy-paste error when the benchmark was created, but this wasn't statically detected until the VarHandle type checks failed due to the long offsets.
Thanks for the review. @liach
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23393#issuecomment-2629214396
More information about the hotspot-compiler-dev
mailing list