RFR: 8342095: Add autovectorizer support for subword vector casts
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Mon Feb 3 05:13:49 UTC 2025
On Mon, 3 Feb 2025 04:40:23 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:
> Hi all,
> This patch adds initial support for the autovectorizer to generate conversions between subword types. Currently, when superword sees two packs that have different basic types, it discards them and bails out of vectorization. This patch changes the behavior to ask the backend if a cast between the conflicting types is supported, and keeps the pack if it is. Later, when the `VTransform` graph is built, a synthetic cast is emitted when packs requiring casts are detected. Currently, only narrowing casts are supported as I wanted to re-use existing `VectorCastX2Y` logic for the initial version, but adding more conversions is simple and can be done with a subsequent RFE. I have attached a JMH benchmark and got these results on my Zen 3 machine:
>
>
> Baseline Patch
> Benchmark (SIZE) Mode Cnt Score Error Units Score Error Units Improvement
> VectorSubword.intToByte 1024 avgt 12 200.049 ± 19.787 ns/op 56.228 ± 3.535 ns/op (3.56x)
> VectorSubword.intToShort 1024 avgt 12 179.826 ± 1.539 ns/op 43.332 ± 1.166 ns/op (4.15x)
> VectorSubword.shortToByte 1024 avgt 12 245.580 ± 6.150 ns/op 29.757 ± 1.055 ns/op (8.25x)
>
>
> I've also added some IR tests and they pass on my linux x64 machine. Thoughts and reviews would be appreciated!
test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.java line 27:
> 25: /*
> 26: * @test
> 27: * @bug 8183390 8340010 8342095
Review note: This test was missing a `@bug` annotation, so I went through the history and added the ones that substantially modified the test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23413#discussion_r1938788814
More information about the hotspot-compiler-dev
mailing list