RFR: 8346774: Use Predicate classes instead of Node classes [v2]

[Christian Hagedorn]

On Mon, 3 Feb 2025 09:35:57 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/predicates.cpp line 813:
>> 
>>> 811:                                                    assertion_expression,
>>> 812:                                                    template_assertion_predicate->assertion_predicate_type());
>>> 813:   return InitializedAssertionPredicate(success_proj);
>> 
>> Suggestion:
>> 
>>   IfTrueNode* success_proj = create_control_nodes(new_control,
>>                                                   template_assertion_predicate->Opcode(),
>>                                                   assertion_expression,
>>                                                   template_assertion_predicate->assertion_predicate_type());
>>   return InitializedAssertionPredicate(success_proj);
>
> Indentation, and: If you split the args over lines, I would at least split all of them consistently.

I usually just make sure that long lines split but don't enforce a single arg per line. But I don't mind adapting to that here :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23234#discussion_r1939148365