RFR: 8346774: Use Predicate classes instead of Node classes [v2]

[Emanuel Peter]

On Mon, 3 Feb 2025 10:34:47 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> This small cleanup PR replaces a lot of usages of `Node` pointers, to pass around either the head (i.e. `IfNode`) or the tail (i.e. a success projection) of predicates, with actual `Predicate` classes. This simplifies the usages, readability and the logical flow, and enables more simplifications in the future, especially once we replace Template Assertion Predicates with a dedicated node.
>> 
>> I've also included some minor refactorings like adding `const` or fixing typos.
>> 
>> There are no semantic changes involved. The return value optimization should take care to avoid a lot of copies when returning new objects from methods. 
>> 
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Review Emanuel
>  - Merge branch 'master' into JDK-8346774
>  - more cleanups
>  - more cleanups
>  - 8346774: Use Predicate classes instead of Node classes

Looks good now!

-------------

Marked as reviewed by epeter (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23234#pullrequestreview-2589633891