RFR: 8343789: Move mutable nmethod data out of CodeCache [v9]
Andrew Haley
aph at openjdk.org
Mon Feb 3 13:56:58 UTC 2025
On Fri, 24 Jan 2025 20:37:32 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
>> This change relocates mutable data (such as relocations, oops, and metadata) from the nmethod. The change follows the recent PR #18984, which relocated immutable nmethod data from the CodeCache.
>>
>> The core idea remains the same: use the CodeCache for executable code while moving additional data to the C heap. The primary motivations are improving security and enhancing code density.
>>
>> Although performance is not the main focus, testing on AArch64 CPUs, where code density plays a significant role, has shown a 1–2% performance improvement in specific scenarios, such as the CodeCacheStress test and the Renaissance Dotty benchmark.
>>
>> The numbers. Immutable data constitutes **~30%** on the nmehtod. Mutable data constitutes **~8%** of nmethod. Example (statistics collected on the CodeCacheStress benchmark):
>> - nmethod_count:134000, total_compilation_time: 510460ms
>> - total allocation time malloc_mutable/malloc_immutable/CodeCache_alloc: 62ms/114ms/6333ms,
>> - total allocation size (mutable/immutable/nmentod): 64MB/192MB/488MB
>>
>> Functional testing: jtreg on arm/aarch/x86.
>> Performance testing: renaissance/dacapo/SPECjvm2008 benchmarks.
>>
>> Alternative solution (see comments): In the future, relocations can be moved to _immutable_data.
>
> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
>
> Force the use of movk in combination with adrp and ldr instructions to address scenarios
> where os::malloc allocates buffers beyond the typical ±4GB range accessible with adrp
src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 328:
> 326:
> 327: // Maybe we have a third instruction: adrp + movk + ldr with offset (e.g. ldr_patchable)
> 328: uint32_t insn3 = insn_at(insn_addr, 2);
As discussed below, it's better not to do this. `adrp()` was never intended to be used in this way, and it's not so efficient to use adrp + movk + ldr with offset rather than movz; movk; movk; ldr (no offset).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21276#discussion_r1939415174
More information about the hotspot-compiler-dev
mailing list