RFR: 8349138: Optimize Math.copySign API for Intel e-core targets [v2]
Jatin Bhateja
jbhateja at openjdk.org
Mon Feb 3 14:21:32 UTC 2025
On Sat, 1 Feb 2025 22:19:57 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adding IR framework verification test
>
> src/hotspot/cpu/x86/x86.ad line 6769:
>
>> 6767:
>> 6768: instruct copySignF_reg_avx(regF dst, regF src, regF xtmp1, regF xtmp2) %{
>> 6769: predicate(!VM_Version::supports_avx512vl());
>
> Suggestion:
>
> predicate(UseAVX > 0 && !VM_Version::supports_avx512vl());
>
> Just to be a bit more explicit (and same for the one below).
Its already handled by match_rule_supported contraint.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23386#discussion_r1939268134
More information about the hotspot-compiler-dev
mailing list