RFR: 8347489: RISC-V: Misaligned memory access with COH [v7]

Fei Yang fyang at openjdk.org
Tue Feb 4 07:06:23 UTC 2025


On Mon, 3 Feb 2025 12:29:47 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Merge branch 'master' into JDK-8347489
>>  - Review comment
>>  - Review comment
>>  - Merge branch 'master' into JDK-8347489
>>  - Merge branch 'master' into JDK-8347489
>>  - Comment
>>  - Fix assertions
>>  - Add assertions
>>  - Comment
>>  - 8347489: RISC-V: Misaligned memory access with COH
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1463:
> 
>> 1461:   {
>> 1462:     if (str1_isL == str2_isL) { // LL or UU
>> 1463: #ifdef ASSERT
> 
> Can we add the some comment about 8-bytes alignment below at line 1520?
> I know it's redundant, but as the code is getting more complicated, it might be good to add it to improve the readability.

Sure. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23053#discussion_r1940606717


More information about the hotspot-compiler-dev mailing list