Integrated: 8346774: Use Predicate classes instead of Node classes

Christian Hagedorn chagedorn at openjdk.org
Tue Feb 4 07:36:17 UTC 2025


On Wed, 22 Jan 2025 13:10:37 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> This small cleanup PR replaces a lot of usages of `Node` pointers, to pass around either the head (i.e. `IfNode`) or the tail (i.e. a success projection) of predicates, with actual `Predicate` classes. This simplifies the usages, readability and the logical flow, and enables more simplifications in the future, especially once we replace Template Assertion Predicates with a dedicated node.
> 
> I've also included some minor refactorings like adding `const` or fixing typos.
> 
> There are no semantic changes involved. The return value optimization should take care to avoid a lot of copies when returning new objects from methods. 
> 
> Thanks,
> Christian

This pull request has now been integrated.

Changeset: c545a3e0
Author:    Christian Hagedorn <chagedorn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c545a3e028ad0760ed2f996e8bb7c56d28e4570a
Stats:     124 lines in 2 files changed: 29 ins; 4 del; 91 mod

8346774: Use Predicate classes instead of Node classes

Reviewed-by: epeter, kvn

-------------

PR: https://git.openjdk.org/jdk/pull/23234


More information about the hotspot-compiler-dev mailing list