RFR: 8346777: Remove unneeded ReplaceInitAndStrideStrategy and add missing const declarations

[Christian Hagedorn]

On Tue, 4 Feb 2025 09:43:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> This patch's main goal is to remove the unneeded `ReplaceInitAndStrideStrategy`. We can use the existing `ReplaceInitAndCloneStrideStrategy` instead. The reason behind is that when splitting a loop as part of a loop optimization, we are always keeping the stride the same (i.e. can use `ReplaceInitAndCloneStrideStrategy`) except for when unrolling a loop. In that case, we keep the init value and update the stride instead. This is done with `UpdateStrideForAssertionPredicates`. `ReplaceInitAndCloneStrideStrategy` was used as an intermediate step while applying more refactorings. It's now time to abandon it.
> 
> I also cover other mostly minor things with this change:
> - Adding missing `const` declarations.
> - Renaming `ctrl` -> `control`
> - Swapping order of parameters
> 
> Thanks,
> Christian

Some last minute updates caused some failures. Moving to draft to look into it again tomorrow.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23434#issuecomment-2634582083