RFR: 8348411: C2: Remove the control input of LoadKlassNode and LoadNKlassNode [v4]

Emanuel Peter epeter at openjdk.org
Tue Feb 4 18:47:25 UTC 2025


On Tue, 4 Feb 2025 18:39:32 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   format
>
> src/hotspot/share/opto/parseHelper.cpp line 170:
> 
>> 168:       !too_many_traps(Deoptimization::Reason_array_check) &&
>> 169:       !tak->klass_is_exact() &&
>> 170:       tak->isa_aryklassptr()) {
> 
> Looks like an implicit `nullptr` check. Not allowed by code style ;)

Can you quickly explain this change from `tak != TypeInstKlassPtr::OBJECT` so I don't need to investigate myself, please?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23274#discussion_r1941715309


More information about the hotspot-compiler-dev mailing list