RFR: 8349374: [JVMCI] concurrent use of HotSpotSpeculationLog can crash

Doug Simon dnsimon at openjdk.org
Tue Feb 4 19:39:16 UTC 2025


On Tue, 4 Feb 2025 17:38:40 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> `failedSpeculationsAddress` also can't be 0 if `managesFailedSpeculations` is false since we throw `IllegalArgumentException` in that case.

Ok, I'd forgotten about that invariant. Might be worth reminding the reader of it with a comment in collectFailedSpeculations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23444#discussion_r1941785813


More information about the hotspot-compiler-dev mailing list