RFR: 8348411: C2: Remove the control input of LoadKlassNode and LoadNKlassNode [v4]

[Emanuel Peter]

On Tue, 4 Feb 2025 18:52:13 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Can you quickly explain this change from `tak != TypeInstKlassPtr::OBJECT` so I don't need to investigate myself, please?
>
>> Looks like an implicit nullptr check. Not allowed by code style ;)
> 
> But the verb here is `isa` and we use these as a `bool` a lot, though :/
> 
>> Can you quickly explain this change from tak != TypeInstKlassPtr::OBJECT so I don't need to investigate myself, please?
> 
> The bottom type of an array can be either `Object` or an array of some kind, so `tak != TypeInstKlassPtr::OBJECT` is the same as `tak->isa_aryklassptr()`.

Ah great, thanks for the explanation!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23274#discussion_r1942520434