RFR: 8348570: CTW: Expose the code hidden by uncommon traps [v4]
Aleksey Shipilev
shade at openjdk.org
Wed Feb 5 15:23:07 UTC 2025
> We have been looking at some related compiler behaviors, and realized that in the absence of profiling data, C2 routinely uncommon-traps a lot of code that is presumed to be never executed. This apparently is a norm in CTW tests: CTW runners never execute code, and so only the most basic java.base classes are having any profile. This seems to limit the scope of CTW testing.
>
> I think we need to run CTW in the mode that exposes more code to the compiler optimizations.
>
> Case in point: [JDK-8348572](https://bugs.openjdk.org/browse/JDK-8348572), which reliably fails with more aggressive compilation mode.
>
> Additional testing:
> - [ ] Linux x86-64 server fastdebug, `applications/ctw/modules`
> - [ ] Linux AArch64 server fastdebug, `applications/ctw/modules`
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Merge branch 'master' into JDK-8348570-ctw-uncommon-traps
- Merge branch 'master' into JDK-8348570-ctw-uncommon-traps
- Also do markMethodProfiled for extra scope
- Fix
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23296/files
- new: https://git.openjdk.org/jdk/pull/23296/files/78fa50c4..c6d1ff12
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23296&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23296&range=02-03
Stats: 2931 lines in 289 files changed: 1803 ins; 528 del; 600 mod
Patch: https://git.openjdk.org/jdk/pull/23296.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23296/head:pull/23296
PR: https://git.openjdk.org/jdk/pull/23296
More information about the hotspot-compiler-dev
mailing list