RFR: 8349361: C2: RShiftL should support all applicable transformations that RShiftI does [v2]

Roland Westrelin roland at openjdk.org
Fri Feb 7 09:57:10 UTC 2025


On Wed, 5 Feb 2025 15:45:08 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 799:
> 
>> 797:     return BitsPerJavaInteger;
>> 798:   }
>> 799:   return BitsPerJavaLong;
> 
> I think it'd be nice to add `assert(bt == T_LONG, "unsupported");` before the last return, like in the helper methods above.

Indeed. Added in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23438#discussion_r1946266019


More information about the hotspot-compiler-dev mailing list