RFR: 8349556: RISC-V: improve the performance when -COH and -AvoidUnalignedAccesses for UL and LU string comparison [v2]
Hamlin Li
mli at openjdk.org
Fri Feb 7 12:29:34 UTC 2025
On Fri, 7 Feb 2025 11:08:41 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refine comments
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 2529:
>
>> 2527:
>> 2528: if (AvoidUnalignedAccesses && (base_offset1 % 8) != 0) {
>> 2529: // Load another 4 bytes from strL to make sure main loop is 8-byte aligned
>
> Nit: You might want to update this code comment removing the word `another`.
> `// Load another 4 bytes from strL to make sure main loop is 8-byte aligned`
> =>
> `// Load 4 bytes from strL to make sure main loop is 8-byte aligned`
Yes, fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23495#discussion_r1946444809
More information about the hotspot-compiler-dev
mailing list