RFR: 8349479: C2: when a Type node becomes dead, make CFG path that uses it unreachable [v2]

Roland Westrelin roland at openjdk.org
Fri Feb 7 13:27:00 UTC 2025


On Thu, 6 Feb 2025 11:44:35 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/node.cpp line 3076:
> 
>> 3074:         assert(r->is_Region() || r->is_top(), "unexpected Phi's control");
>> 3075:         if (r->is_Region()) {
>> 3076:           for (uint k = 1; k < u->req(); ++k) {
> 
> `k` already defined as `DUIterator_Fast` earlier, can we choose a different name?

Good catch. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23468#discussion_r1946518884


More information about the hotspot-compiler-dev mailing list