RFR: 8349582: APX NDD code generation for OpenJDK [v2]
Srinivas Vamsi Parasa
sparasa at openjdk.org
Fri Feb 7 21:53:41 UTC 2025
On Fri, 7 Feb 2025 09:15:22 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> revert to nf version for {pop/tz/lz}cnt count instructions
>
> src/hotspot/cpu/x86/x86_64.ad line 5804:
>
>> 5802: %}
>> 5803:
>> 5804: instruct countTrailingZerosL_mem_nf(rRegI dst, memory src, rFlagsReg cr) %{
>
> Why are we using rflagsReg operand for Non-Flags affecting patterns?
Thanks for the catch! Please see the updated NF code for count instructions which reverted to the previous implementation which does not use the CR flags.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23501#discussion_r1947239459
More information about the hotspot-compiler-dev
mailing list