RFR: 8349579: jsvml.dll incorrect RDATA SEGMENT specification

Sandhya Viswanathan sviswanathan at openjdk.org
Tue Feb 11 02:46:10 UTC 2025


On Thu, 6 Feb 2025 21:34:39 GMT, Mohamed Issa <duke at openjdk.org> wrote:

> A fix for incorrectly defined program segments in Windows SVML assembly.
> 
> - Changes _READ_ to _READONLY_ in all math functions
> - Now compliant with MASM x86 and x86_64 program segment [specification](https://learn.microsoft.com/en-us/cpp/assembler/masm/segment?view=msvc-170)
> 
> The tier1 tests show the changes didn't introduce new failures.

Looks good to me.

-------------

Marked as reviewed by sviswanathan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23503#pullrequestreview-2607579720


More information about the hotspot-compiler-dev mailing list