RFR: 8349579: jsvml.dll incorrect RDATA SEGMENT specification [v2]
Jatin Bhateja
jbhateja at openjdk.org
Tue Feb 11 07:53:09 UTC 2025
On Tue, 11 Feb 2025 03:44:27 GMT, Mohamed Issa <duke at openjdk.org> wrote:
>> A fix for incorrectly defined program segments in Windows SVML assembly.
>>
>> - Changes _READ_ to _READONLY_ in all math functions
>> - Now compliant with MASM x86 and x86_64 program segment [specification](https://learn.microsoft.com/en-us/cpp/assembler/masm/segment?view=msvc-170)
>>
>> The tier1 tests show the changes didn't introduce new failures.
>
> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
>
> Update full name
dumpbin shows no difference in section attributes with and without patch. But, its good to comply with specification.
```
dumpbin /nologo /SECTION:_RDATA jsvml.dll
40000040 flags
Initialized Data
Read Only
-------------
Marked as reviewed by jbhateja (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23503#pullrequestreview-2607929875
More information about the hotspot-compiler-dev
mailing list