RFR: 8349764: RISC-V: C1: Improve Class.isInstance intrinsic [v2]
Gui Cao
gcao at openjdk.org
Thu Feb 13 04:23:17 UTC 2025
On Thu, 13 Feb 2025 01:14:37 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update for Hamlin's comment
>
> src/hotspot/cpu/riscv/c1_Runtime1_riscv.cpp line 953:
>
>> 951: __ ld(x17, Address(x17));
>> 952: __ beq(klass, x17, success);
>> 953: __ j(fail);
>
> Hmm, I think this jump could be saved if we put a direct return here instead. Like:
>
> __ beq(klass, x17, success);
> __ mv(result, 0);
> __ ret();
>
> What do you think? @Hamlin-Li @zifeihan
Yes, I think we can put a direct return here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23551#discussion_r1953780219
More information about the hotspot-compiler-dev
mailing list