RFR: 8347645: C2: XOR bounded value handling blocks constant folding [v26]
Emanuel Peter
epeter at openjdk.org
Thu Feb 13 08:40:14 UTC 2025
On Sat, 1 Feb 2025 19:31:00 GMT, Johannes Graham <duke at openjdk.org> wrote:
>> Johannes Graham has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add IR tests for long, simplify tests for int
>
> Thanks. I've done another round of format fixing. I've also simplified the IR tests so they don't try to cover as much as gtest does, and added equivalent tests for long.
>
> I have temporarily left the more elaborate tests commented out in XorINodeIdealizationTests. I will remove them if nobody thinks they are worth keeping.
@j3graham Can you please update the PR description at the top? The current version does not reflect the most up-to-date explanations, right?
I would like to see a nice summary, what cases were covered before and what cases you are now covering additionally.
Give a quick explanation how you changed the code.
I'll increase the number of reviewers as this looks like a substantial change.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23089#issuecomment-2655880238
More information about the hotspot-compiler-dev
mailing list