RFR: 8347645: C2: XOR bounded value handling blocks constant folding [v27]
Johannes Graham
duke at openjdk.org
Thu Feb 13 19:47:15 UTC 2025
On Thu, 13 Feb 2025 09:54:22 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> I think the comment should be removed, the specs and implementation of `calc_xor_max` should be referred to when trying to understand this piece of code.
>
> I think a better name like `calculate_upper_bound_of_xor_with_non_negative_inputs` would help a lot, and make some comments redundant.
I have removed the comment - it was left over from the original code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23089#discussion_r1955118824
More information about the hotspot-compiler-dev
mailing list