RFR: 8347645: C2: XOR bounded value handling blocks constant folding [v27]
Johannes Graham
duke at openjdk.org
Thu Feb 13 19:54:13 UTC 2025
On Thu, 13 Feb 2025 09:50:48 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> I think the name is good enough, calculate the max of a xor is a pretty self-explanatory name. You just need a better description for the method. Suggestion:
>>
>> Given 2 non-negative values in the ranges [0, hi_0] and [0, hi_1], respectively. The bitwise xor of these values should also be non-negative. This method calculates its maximum.
>
> What about calling it `calculate_upper_bound_of_xor_with_non_negative_inputs`?
I've gone with `calc_xor_upper_bound_of_non_neg` and added the clarifying method description.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23089#discussion_r1955126507
More information about the hotspot-compiler-dev
mailing list