RFR: 8350006: IGV: show memory slices as type information [v2]

[Roberto Castañeda Lozano]

On Fri, 14 Feb 2025 12:23:06 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>>> I assume `mem:6` is the same `6` as `6: int` at `Start`.
>> 
>> No, `6` in `mem:6` is the index of the memory slice defined by `94 StoreI`, whereas `6:int` in `3 Start` indicates that the element number 6 of the tuple defined by `3 Start` is of type `int`.
>
>> > I assume `mem:6` is the same `6` as `6: int` at `Start`.
>> 
>> No, `6` in `mem:6` is the index of the memory slice defined by `94 StoreI`, whereas `6:int` in `3 Start` indicates that the element number 6 of the tuple defined by `3 Start` is of type `int`.
> 
> @merykitty would it be less confusing if the memory node type was presented as e.g. `mem: idx=6` instead of just `mem: 6`? We try to keep IGV node labels as compact as possible because wide nodes kill graph readability, but adding `idx=` would not hurt much if it makes it easier to interpret the type information.

> @robcasloz I think adding `idx=` would not help, I can instinctively understand that `6` here is the index of the memory slice.

OK, great.

> What I can't see from the IGV is what that slice is. It may be helpful if we can dump all the memory slice details somewhere. For example at the `Root` node or the `Start` node. What do you think?

What memory slice details do you mean? Could you perhaps give an example of what additional information you would like to see?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23621#issuecomment-2659232163