RFR: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases [v3]

Jasmine Karthikeyan jkarthikeyan at openjdk.org
Fri Feb 14 13:56:12 UTC 2025


On Fri, 14 Feb 2025 13:01:15 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve explanation of logic
>
> test/hotspot/jtreg/compiler/vectorization/TestNumberOfContinuousZeros.java line 27:
> 
>> 25: /**
>> 26: * @test
>> 27: * @bug 8297172 8331993 8349637
> 
> Drive-by comment.
> The `@requires` below are really a shame. This test now is not run in other places, so we would not catch issues elsewhere.

I was thinking about refactoring the test with this in mind and using the `Generators` api for creating random values, but I thought that if we were planning on backporting this to older releases (since this bug affects 21 and 24 too) it might be better to do it separately to keep the diff small. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23579#discussion_r1956184917


More information about the hotspot-compiler-dev mailing list