RFR: 8349908: RISC-V: C2 SelectFromTwoVector [v2]

[Fei Yang]

On Mon, 17 Feb 2025 13:44:18 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/riscv_v.ad line 103:
>> 
>>> 101:         break;
>>> 102:       case Op_SelectFromTwoVector:
>>> 103:         return true;
>> 
>> Seems not necessary to add one more case here as the default will return true for this case.
>
> Logically, yes. It's not necessary, my thought is to make the code explicit, so friendly to read code. But I can remove it if you think it's better to do so.

Yes, please. The practice here is to only list the opcodes whose availability would also depend on some other facts like vector size, etc.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23614#discussion_r1958288153