RFR: 8350159: compiler/tiered/Level2RecompilationTest.java fails after JDK-8349915

Aleksey Shipilev shade at openjdk.org
Mon Feb 17 18:15:17 UTC 2025


On Mon, 17 Feb 2025 18:10:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/compiler/compilationPolicy.cpp line 636:
>> 
>>> 634:       continue;
>>> 635:     }
>>> 636:     if (task->is_blocking() && task->compile_reason() == CompileTask::Reason_Whitebox) {
>> 
>> This may be not enough - testing with `-Xcomp` sets `-Xbatch`: [arguments.cpp#L1358](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L1358)
>
> On other hand, when running with `-Xcomp` we should not worry about priority of compilation tasks.
> And `Level2RecompilationTest.java` "requires" `vm.compMode != "Xcomp"` so it should pass.

Yes. Testing confirms both the affected test and CTW works fine.

I think the cleanest way is to tell `Whitebox` whether we are entering for CTW, or for faking a normal compilation. But it would significantly more intrusive.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23668#discussion_r1958651531


More information about the hotspot-compiler-dev mailing list