RFR: 8350006: IGV: show memory slices as type information [v3]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Feb 18 12:17:11 UTC 2025


On Tue, 18 Feb 2025 08:41:55 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Dump alias type information for each node
>
> src/hotspot/share/opto/idealGraphPrinter.cpp line 555:
> 
>> 553:           field->print_name_on(&field_stream);
>> 554:           print_prop("alias_field", field_stream.freeze());
>> 555:         }
> 
> I'm not sure if this is really required. There is already the "source" and "destination" dump for loads and stores, respectively:
> 
> https://github.com/openjdk/jdk/blob/3353f8e0875165adbc8ee764a4c8d8817a87cd88/src/hotspot/share/opto/idealGraphPrinter.cpp#L695-L718
> 
> This also shows information for array accesses. For example:
> ![image](https://github.com/user-attachments/assets/0d60fe56-aee8-4450-a680-78a2ac470d4b)

You are right, thanks, I overlooked the `source` and `destination` properties. Commit cd2645cf removes `alias_field`. The example visualization shown above can be obtained using something like `[idx] [name] ([alias_index] : [source][destination])` as a "Node Text" value.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23621#discussion_r1959628944


More information about the hotspot-compiler-dev mailing list