RFR: 8349180: Remove redundant initialization in ciField constructor

Christian Hagedorn chagedorn at openjdk.org
Tue Feb 18 19:25:14 UTC 2025


On Tue, 18 Feb 2025 08:56:42 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> In `ciField`'s ctor, `_name` is initialized twice. I think we can indeed apply the suggested fix and remove the second assignment. `_name` is set correctly the first time (and without the useless cast), and not modified in between.
>> 
>> Thanks,
>> Marc
>
>> Hello @marc-chevalier! I have already open a PR for this matter. PR is #23480.
> 
> Hi @gustavosimon, the JBS issue was already assigned to @marc-chevalier. If you intend to work on an issue, please check the following:
> - The issue is already assigned in JBS?
>   - Reach out to the assignee and ask if the person is currently working on the issue or has intentions to do so. If not, they can reassign it to you or someone else on your behalf (if you don't have a JBS account).
> - The issue is unassigned in JBS? 
>   - Assign the issue to yourself.
>   - If you don't have a JBS account: Reach out to someone who can assign it to him/herself on your behalf.
> 
> 
> This avoids "stealing" work that was in progress or planned to do later or even worse doing completely duplicated work which is unfortunate.

> @chhagedorn Got it. Actually, when I started working on this, the issue was unassigned.

Oh, I see - looks like an unfortunate timing!

> I will ask to @RealCLanger to assign it to me next times.

Sounds good :-)

> Can you review my OCA verification?

We pinged @robilad to review it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23637#issuecomment-2666025700


More information about the hotspot-compiler-dev mailing list