Integrated: 8350159: compiler/tiered/Level2RecompilationTest.java fails after JDK-8349915
Aleksey Shipilev
shade at openjdk.org
Wed Feb 19 11:36:59 UTC 2025
On Mon, 17 Feb 2025 17:04:41 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Recently added hunk in `CompilationPolicy::selected_task` was supposed to target CTW runs, that wanted to omit any level changes. But there are tests that _do test_ level changes, and they submit `Whitebox` requests. One of those tests is `compiler/tiered/Level2RecompilationTest.java`. So it looks like we need to disambiguate the "CTW" uses and "general Whitebox" uses.
>
> Looks like checking for `-Xbatch` does the trick for CTW. It is not super-clean, but it works, and it matches other exceptions in around compilation policy, e.g. when checking for `-Xcomp`, etc.
>
> Additional testing:
> - [x] Linux AArch64 server fastdebug, `compiler/tiered/Level2RecompilationTest.java` now passes
> - [x] Linux AArch64 server fastdebug, CTW tests still work fine
> - [x] Linux AArch64 server fastdebug, `all`
This pull request has now been integrated.
Changeset: 79db2d41
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/79db2d4186eb2af827295581464be8602ac95f98
Stats: 5 lines in 2 files changed: 0 ins; 2 del; 3 mod
8350159: compiler/tiered/Level2RecompilationTest.java fails after JDK-8349915
Reviewed-by: kvn, chagedorn
-------------
PR: https://git.openjdk.org/jdk/pull/23668
More information about the hotspot-compiler-dev
mailing list