RFR: 8347645: C2: XOR bounded value handling blocks constant folding [v31]

[Johannes Graham]

On Tue, 18 Feb 2025 02:32:02 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:

>> Johannes Graham has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 45 commits:
>> 
>>  - Merge branch 'openjdk:master' into xor_const
>>  - fix variable names in comments
>>  - update test
>>  - address review comments
>>  - formatting, remove commented tests
>>  - add IR tests for long, simplify tests for int
>>  - formatting
>>  - add sanity asserts to tests
>>  - re-add tests
>>  - try fewer tests
>>  - ... and 35 more: https://git.openjdk.org/jdk/compare/ff52859d...16049cdc
>
> test/hotspot/jtreg/compiler/c2/irTests/XorINodeIdealizationTests.java line 315:
> 
>> 313: 
>> 314:     @Test
>> 315:     public int testXorConstRange(int x, int y) {
> 
> Should this have an `@IR` test attached, like `testFoldableXor`?

This test is really there to do a minimal correctness test of the xor calculation, rather than verifying the IR. The xor is not expected to be eliminated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23089#discussion_r1963846393