RFR: 8321003: RISC-V: C2 MulReductionVI [v6]

Hamlin Li mli at openjdk.org
Thu Feb 20 19:32:30 UTC 2025


On Thu, 20 Feb 2025 06:11:51 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix unordered
>>  - fix
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.hpp line 244:
> 
>> 242:   void reduce_mul_integral_v(Register dst, Register src1, VectorRegister src2,
>> 243:                              VectorRegister vtmp1, VectorRegister vtmp2, BasicType bt,
>> 244:                              uint len, VectorMask vm = Assembler::unmasked);
> 
> Do you mind renaming this param `len` to `vector_length`? Then it will be consistent with friends `compare_integral_v`, `compare_fp_v`, etc in param naming.

sure, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23580#discussion_r1964218022


More information about the hotspot-compiler-dev mailing list