RFR: 8350383: Test: add more test case for string compare (UL case)

Fei Yang fyang at openjdk.org
Fri Feb 21 02:03:53 UTC 2025


On Wed, 19 Feb 2025 20:04:01 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this simple test case improvement?
> 
> Compared to LL/UU/LU string compare, UL case seems not enough to cover all the code path in intrinsics. This patch is to add these test case for UL string compare.
> 
> NOTE: 
> * L means string in Latin, 
> * U means string in utf, 
> * LL string compare means L.compareTo(L),
> * LU string compare means L.compareTo(U),
> * and so on.
> 
> Thanks!

Looks good to me. Will this cover the case we discussed? https://github.com/openjdk/jdk/pull/23633#discussion_r1960826250

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23705#pullrequestreview-2631643599


More information about the hotspot-compiler-dev mailing list