Integrated: 8321003: RISC-V: C2 MulReductionVI

[Hamlin Li]

On Wed, 12 Feb 2025 09:52:09 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this patch to implement MulReductionVI/MulReductionVL/MulReductionVF/MulReductionVD?
> This optimization is mainly for the vector API.
> On riscv, there is no straightforward instructions to do it, but we can do it with a reduction tree, which could reduce the time complexity to lg(N).
> 
> 
> Thanks
> 
> ## Test
> 
> ### jtreg
> test/jdk/jdk/incubator/vector/
> 
> ### Performance
> 
> run on bananapi
> 
> master vs patch
> <google-sheets-html-origin style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;">
> Benchmark | (size) | Mode | Cnt | Score - master | Error - patch | Score - patch | Error - patch | Units | Improvement
> -- | -- | -- | -- | -- | -- | -- | -- | -- | --
> ByteMaxVector.MULLanes | 1024 | avgt | 10 | 11170.052 | 499.676 | 1294.424 | 8.346 | ns/op | 88.40%
> ByteMaxVector.MULMaskedLanes | 1024 | avgt | 10 | 12514.587 | 55.06 | 1413.028 | 0.259 | ns/op | 88.70%
> DoubleMaxVector.MULLanes | 1024 | avgt | 10 | 57672.51 | 1750.417 | 4775.633 | 1.454 | ns/op | 91.70%
> DoubleMaxVector.MULMaskedLanes | 1024 | avgt | 10 | 63656.523 | 1063.048 | 5899.259 | 1.692 | ns/op | 90.70%
> FloatMaxVector.MULLanes | 1024 | avgt | 10 | 30997.218 | 728.73 | 2473.069 | 5.84 | ns/op | 92.00%
> FloatMaxVector.MULMaskedLanes | 1024 | avgt | 10 | 35515.329 | 227.873 | 3284.17 | 0.608 | ns/op | 90.80%
> IntMaxVector.MULLanes | 1024 | avgt | 10 | 31130.453 | 878.261 | 3304.118 | 5.96 | ns/op | 89.40%
> IntMaxVector.MULMaskedLanes | 1024 | avgt | 10 | 36851.976 | 394.001 | 3969.407 | 0.511 | ns/op | 89.20%
> LongMaxVector.MULLanes | 1024 | avgt | 10 | 58795.752 | 1030.985 | 6883.995 | 3.15 | ns/op | 88.30%
> LongMaxVector.MULMaskedLanes | 1024 | avgt | 10 | 63642.904 | 386.521 | 7892.735 | 9.359 | ns/op | 87.60%
> ShortMaxVector.MULLanes | 1024 | avgt | 10 | 16857.441 | 762.428 | 2287.141 | 0.186 | ns/op | 86.40%
> ShortMaxVector.MULMaskedLanes | 1024 | avgt | 10 | 21171.375 | 74.684 | 2532.913 | 0.274 | ns/op | 88.00%
> 
> </google-sheets-html-origin>

This pull request has now been integrated.

Changeset: 1b6281d9
Author:    Hamlin Li <mli at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1b6281d98cf0e7c5435c563bfedd6f07b79bfa62
Stats:     124 lines in 6 files changed: 123 ins; 0 del; 1 mod

8321003: RISC-V: C2 MulReductionVI
8321004: RISC-V: C2 MulReductionVL

Reviewed-by: fyang, rehn

-------------

PR: https://git.openjdk.org/jdk/pull/23580