RFR: 8349523: Unused runtime calls to drem/frem should be removed
Quan Anh Mai
qamai at openjdk.org
Fri Feb 21 14:07:54 UTC 2025
On Thu, 20 Feb 2025 14:18:40 GMT, Marc Chevalier <duke at openjdk.org> wrote:
> It surely would be nice, but it feels out of scope.
I strongly disagree with this sentiment. This patch fixes one particular issue (dead code elimination) with 1 particular kind of operation (floating-point remainder, which is IMO a really niche operation). This patch does not fix other issues (GVN, scheduling, floating-point remainder alters memory unnecessarily, etc) or does not fix the issue with other similar operations. I don't think the benefits justify adding this band-aid.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23694#issuecomment-2674639653
More information about the hotspot-compiler-dev
mailing list