RFR: 8349523: Unused runtime calls to drem/frem should be removed [v2]
Marc Chevalier
duke at openjdk.org
Fri Feb 21 15:41:34 UTC 2025
On Thu, 20 Feb 2025 22:16:38 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> Can we reuse `replace_with_con()` here?
That is a good point. Actually, I had to fix it a bit: it uses `Compile::gvn_replace_by` but is actually only called by `Mod{D,F}Node::Ideal` which both starts with
https://github.com/openjdk/jdk/blob/dfcd0df60c60cf89dc01682264a573ad39e61a17/src/hotspot/share/opto/divnode.cpp#L1560-L1562
so actually run only in IGVN. It's benign, but useless work: `PhaseIterGVN::replace_node` is better fit: it does the rewiring and add to the worklist as well, but doesn't do the hashing magic.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23694#issuecomment-2674877423
More information about the hotspot-compiler-dev
mailing list