RFR: 8349032: C2: Parse Predicate refactoring in Loop Unswitching broke fix for JDK-8290850 [v2]
Christian Hagedorn
chagedorn at openjdk.org
Fri Feb 21 22:31:15 UTC 2025
On Thu, 20 Feb 2025 17:53:28 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> restore comment line length
>
> src/hotspot/share/opto/loopPredicate.cpp line 100:
>
>> 98: // new_iff is returned which is an IfTrue projection. This code is also used to clone predicates to cloned loops.
>> 99: // 'rewire_uncommon_proj_phi_inputs' should be set to the non-default value 'true' when called for a false-path loop
>> 100: // during Loop Unswitching.
>
> Just nitpick. Can you return back length of comment's lines?
Yes sure, done in new commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23712#discussion_r1966278487
More information about the hotspot-compiler-dev
mailing list