RFR: 8350095: RISC-V: Refactor string_compare [v3]
Fei Yang
fyang at openjdk.org
Mon Feb 24 10:52:52 UTC 2025
On Mon, 24 Feb 2025 10:01:25 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1618:
>>
>>> 1616: }
>>> 1617:
>>> 1618: bind(STUB);
>>
>> Consider moving this STUB generation code to the new subroutines at the same time.
>
> It's better to keep it as it is, they are different logics, and if moving it then the 2 new subroutines will need to access the SHORT_* Labels by passing more parameters.
Make sense. Will take a look at the latest version. Thanks for the update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23633#discussion_r1967400128
More information about the hotspot-compiler-dev
mailing list