RFR: 8349361: C2: RShiftL should support all applicable transformations that RShiftI does [v7]

Roland Westrelin roland at openjdk.org
Mon Feb 24 13:09:55 UTC 2025


On Thu, 13 Feb 2025 10:46:25 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> @rwestrel nice work, looks like a good step to unify the code a little!
> 
> I left some comments / suggestions.
> 
> I'm also wondering about testing. How good do you think test coverage is? Are all cases covered? How about the edge-cases? Could we improve the coverage with randomization somehow?

@eme64 can you take another look?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23438#issuecomment-2678367268


More information about the hotspot-compiler-dev mailing list