RFR: 8339889: Several compiler tests ignore vm flags and not marked as flagless [v2]

Leonid Mesnik lmesnik at openjdk.org
Mon Feb 24 20:41:56 UTC 2025


On Mon, 17 Feb 2025 08:27:28 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

> Thanks for "cleaning this up" @lmesnik.
> 
> I just ran a quick grep on `test/hotspot/jtreg/compiler` and noticed that there are a few more tests that use `ProcessTools.createLimitedTestJavaProcessBuilder` but don't have `vm.flagless` and don't seem to be covered by other JBS issues (e.g. `compiler/codecache/CheckLargePages.java`, `compiler/onSpinWait/TestOnSpinWaitAArch64DefaultFlags.java`, `compiler/jvmci/TestUncaughtErrorInCompileMethod.java` or `compiler/jvmci/compilerToVM/GetFlagValueTest.java`). Their main method runs in a new VM (`@run main/othervm`) but then they run other processes with `ProcessTools.createLimitedTestJavaProcessBuilder `. As I understand, vm flags would only affect the main method (which supposedly is not what is being tested). So, I was wondering if it made sense to mark them flagless as well anyway.

Thanks,  we have a list of bugs to fix:
I filed 
https://bugs.openjdk.org/browse/JDK-8350603

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23224#issuecomment-2679592774


More information about the hotspot-compiler-dev mailing list