RFR: 8347405: MergeStores with reverse bytes order value [v11]
Emanuel Peter
epeter at openjdk.org
Wed Feb 26 10:58:32 UTC 2025
On Wed, 26 Feb 2025 10:50:23 GMT, kuaiwei <duke at openjdk.org> wrote:
>> To me the 3 nitpicks are optional, you don't have to apply them.
>> Also I saw we already tested commit 16 / v10. I did launch testing again, just because there were a few weeks since the last time and sometimes bugs sneak via bad merges.
>>
>> Approved. But it would be good to have a second reviewer give an approval too.
>>
>> I'm excited to see what you do with this one 😊
>> [JDK-8345485](https://bugs.openjdk.org/browse/JDK-8345485) C2 MergeLoads: merge adjacent array/native memory loads into larger load
>
>> To me the 3 nitpicks are optional, you don't have to apply them. Also I saw we already tested commit 16 / v10. I did launch testing again, just because there were a few weeks since the last time and sometimes bugs sneak via bad merges.
>>
>> Approved. But it would be good to have a second reviewer give an approval too.
>>
>> I'm excited to see what you do with this one 😊 [JDK-8345485](https://bugs.openjdk.org/browse/JDK-8345485) C2 MergeLoads: merge adjacent array/native memory loads into larger load
>
> Thanks for your approval. I've fixed as comments.
@kuaiwei Would you mind merging with master? Then we can run testing with the most up-to-date version and have a lower risk of bad merges on integration ;)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23030#issuecomment-2684611208
More information about the hotspot-compiler-dev
mailing list