RFR: 8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails

[Claes Redestad]

On Tue, 25 Feb 2025 02:24:33 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> The newly added JMH test jdk.incubator.vector.VectorCommutativeOperSharingBenchmark run fails "java.lang.NoClassDefFoundError: jdk/incubator/vector/Vector".
> 
> The `@Fork(jvmArgsPrepend = ..)` in microbenchmarks should replaced as `@Fork(jvmArgs = ..)` after [JDK-8343345](https://bugs.openjdk.org/browse/JDK-8343345). Change has been verified locally, test-fix only, no risk.

LGTM

Yes, please use only `jvmArgs` in `@Fork` annotations. While the distinction between `jvmArgs`, `-Prepend` and `-Append` is  subtle and somewhat arbitrary we opted ([JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958) + [JDK-8343345](https://bugs.openjdk.org/browse/JDK-8343345)) to designate `jvmArgs` to be used in benchmark annotations to set benchmark-specific flags, reserving `jvmArgsPrepend` for use by `make test` or whatever benchmarking harness you might use to set up environment flags (such as the native library path), and leaving `jvmArgsAppend` for command line extras (specifying GC etc).

-------------

Marked as reviewed by redestad (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23761#pullrequestreview-2647301378