RFR: 8347040: C2: assert(!loop->_body.contains(in)) failed
Roland Westrelin
roland at openjdk.org
Thu Feb 27 16:49:59 UTC 2025
On Thu, 27 Feb 2025 15:33:24 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> `OuterStripMinedLoopNode::transform_to_counted_loop()` merges the
>> outer strip mined loop and the inner loop into a single loop. To
>> achieve that, it needs to append the nodes of the outer strip mined
>> loop to the body of the inner loop. To make sure each of these nodes
>> is appended only once, a `Unique_Node_List` is used: nodes found by
>> following the safepoint's inputs are first enqueued into the list and
>> then, each unique node should be added to the loop body. That's not
>> what the current code does, though, because it enqueues the nodes it
>> finds to the list and add them to the loop body right away.
>
> That looks good to me.
@chhagedorn @vnkozlov thanks for the reviews
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23676#issuecomment-2688532742
More information about the hotspot-compiler-dev
mailing list