RFR: 8349361: C2: RShiftL should support all applicable transformations that RShiftI does [v10]
Roland Westrelin
roland at openjdk.org
Thu Feb 27 16:57:27 UTC 2025
On Mon, 24 Feb 2025 15:39:19 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
>>
>> - review
>> - Merge branch 'master' into JDK-8349361
>> - review
>> - review
>> - review
>> - Merge branch 'master' into JDK-8349361
>> - Update src/hotspot/share/opto/mulnode.cpp
>>
>> Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>> - Update src/hotspot/share/opto/mulnode.cpp
>>
>> Co-authored-by: Emanuel Peter <emanuel.peter at oracle.com>
>> - review
>> - Update src/hotspot/share/opto/mulnode.hpp
>>
>> Co-authored-by: Jasmine Karthikeyan <25208576+jaskarth at users.noreply.github.com>
>> - ... and 7 more: https://git.openjdk.org/jdk/compare/c4fb8d3d...d3b1cf08
>
> src/hotspot/share/opto/mulnode.cpp line 1417:
>
>> 1415: if (shift == 0) return t1;
>> 1416: // Calculate reasonably aggressive bounds for the result.
>> 1417: // This is necessary if we are to correctly type things
>
> This is the same code as above, right? As commented above: it would be good to not move it and reduce the size of the diff.
I reordered the changes. Can you take another look?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23438#discussion_r1973986205
More information about the hotspot-compiler-dev
mailing list