RFR: 8315488: SA ciReplay support is no longer up-to-date with hotspot ciReplay support [v6]

Vladimir Kozlov kvn at openjdk.org
Fri Feb 28 16:47:59 UTC 2025


On Fri, 28 Feb 2025 15:59:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change removes the ci, c1 and c2 compiler code from the serviceability agent.  The ciReplay functionality is supported inside the jvm and this duplicated functionality in SA had bit rotted so is removed.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove VM_STRUCTS macro arguments.

Zero build is broken:

src/hotspot/share/runtime/vmStructs.cpp:1321:46: error: ‘COMPILER2’ was not declared in this scope; did you mean ‘NOT_COMPILER2’?
 1321 |   declare_preprocessor_constant("COMPILER2", COMPILER2)                   \
      |                                              ^~~~~~~~~

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23782#issuecomment-2691102469


More information about the hotspot-compiler-dev mailing list