RFR: 8343763: Aarch64: Gtest codestrings.validate_vm intermittent fails extra addr

[Andrew Haley]

On Thu, 7 Nov 2024 13:43:10 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> The `Gtest codestrings.validate_vm` intermittent fails with different disassembly symbol name, such as different symbol name with instruction `adrp`/`b` etc. I think the difference of symbol name is acceptable, this PR remove the releated symbol name to make the fragile disassemble identical compare more robustness.
> The change has been verified locally, the gtest test run with 20k times all passed, except sometimes the subtest `ThreadsListHandle::sanity_vm` intermittent fails which has been recorded by [JDK-8315141](https://bugs.openjdk.org/browse/JDK-8315141). Test-fix only, no risk.

test/hotspot/gtest/code/test_codestrings.cpp line 53:

> 51:     std::basic_string<char> tmp6 = std::regex_replace(tmp5, std::regex("adrp[\\\\t\\s]+([wx][0-9]+).*"), "adrp $1 = <addr>");
> 52:     std::basic_string<char> tmp7 = std::regex_replace(tmp6, std::regex(", \\w+::\\w+.*"), "");
> 53:     std::basic_string<char> tmp8 = std::regex_replace(tmp7, std::regex("\\s+<addr>:\\s+udf\\t#0"), "");

It would help this reviewer if you added some commentary that explains what's going on. An example of the AArch64 output would be nice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21955#discussion_r1903231295